| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
RE the Codacy issues - _isHeterogenousPipedInput and _lastInputType exist as fields as their values must persist between calls to the method it's used in. I'll take care of the rest. The Static Analysis link failure is unrelated, possibly an older page was taken down: 2019-01-17T17:09:58.2571685Z [-] http://www.powershellmagazine.com/2014/04/24/windows-powershell-4-0-and-other-quick-reference-guides/ should work 131.74s 2019-01-17T17:09:58.3083022Z RuntimeException: retry of url failed with error: 2019-01-17T17:09:58.3092376Z at <ScriptBlock>, /home/vsts/work/1/s/test/common/markdown/markdown-link.tests.ps1: line 109 EDIT: Seems fine now. Weird. |
Sorry, something went wrong.
|
Codacy is a little wonky at times, it seems. Its request to make the methods static cannot be resolved, for example if we try to make the methods static we get an error on the WriteObject() calls: |
Sorry, something went wrong.
|
Rain Sallow (/u/ta11ow) (@vexx32) Thanks for the great contribution! |
Sorry, something went wrong.
|
Ilya (@iSazonov) yeah, that makes sense. Will do! |
Sorry, something went wrong.
|
Close & Reopen to restart failing xUnit test on Windows. Don't think that should have been affected by anything here. |
Sorry, something went wrong.
|
/cc Ilya (@iSazonov) James Truher (@JamesWTruher) Paul Higinbotham (@PaulHigin) Style changes PR was #8683 and is merged. This one's just pending your guys review, I think? Let me know. 😄 |
Sorry, something went wrong.
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
Sorry, something went wrong.
|
Ping Paul Higinbotham (@PaulHigin) for review. 😃 |
Sorry, something went wrong.
|
Rain Sallow (/u/ta11ow) (@vexx32) I reviewed this again. I think we could close the PR as controversial and continue the discussion in an issue:
I doubt it is necessary. Perhaps this is exactly what users want in some scenarios.
Looks useful in all scenarious. |
Sorry, something went wrong.
|
If we must, we must. 🤷♂️ I'm inclined to think that users would find its current behaviour when piping a byte stream/array to it extremely useless, but that's just me. But if I'm honest, it may well be just that it doesn't need the behaviour as it isn't used extensively. |
Sorry, something went wrong.
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs within 10 days. |
Sorry, something went wrong.
|
Rain Sallow (/u/ta11ow) (@vexx32) Please resolve the merge conflict. I think we need rebase to get latest CIs updates. |
Sorry, something went wrong.
|
Ilya (@iSazonov) done and done. Let's see how CI runs fare. 😄 |
Sorry, something went wrong.
|
Andrew (@anmenaga) ping for review. 🙂 |
Sorry, something went wrong.
There was a problem hiding this comment.
not blocking.
one comment about the new tests (and i suppose a reflection on all the tests for this).
Sorry, something went wrong.
|
Ilya (@iSazonov) updated tests to account for behavioural changes and updated the PR description to hopefully clarify what's going on. If anything still isn't clear, please let me know! 💖 |
Sorry, something went wrong.
|
PoshChan-Bot (@PoshChan) please retry macos |
Sorry, something went wrong.
|
Rain Sallow (/u/ta11ow) (@vexx32), successfully started retry of PowerShell-CI-macOS |
Sorry, something went wrong.
|
PoshChan-Bot (@PoshChan) Please remind me in 1 day |
Sorry, something went wrong.
|
Ilya (@iSazonov), this is the reminder you requested 1 day ago |
Sorry, something went wrong.
|
Steve Lee (@SteveL-MSFT) Travis Plunk (@TravisEz13) Keith Hill (@rkeithhill) The PR is ready for final code review. |
Sorry, something went wrong.
| } | ||
| else | ||
| { | ||
| WriteHexadecimal(bytes, offset: 0, label: GetGroupLabel(typeof(string))); |
There was a problem hiding this comment.
Should either consistently name the label param or don't, but it's a bit inconsistent.
Sorry, something went wrong.
There was a problem hiding this comment.
I think I'll opt for naming it, since one of the other possible overloads also has a string param (path), so it's safer to name this one.
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM, one NIT comment
Sorry, something went wrong.
|
PoshChan-Bot (@PoshChan) please retry static |
Sorry, something went wrong.
|
Rain Sallow (/u/ta11ow) (@vexx32), successfully started retry of PowerShell-CI-static-analysis |
Sorry, something went wrong.
|
Oh, I guess MSDN is down for a bit. 😄 |
Sorry, something went wrong.
|
retried the URL check |
Sorry, something went wrong.
|
Added doc issue reference to PR template: MicrosoftDocs/PowerShell-Docs#4532 |
Sorry, something went wrong.
|
🎉v7.0.0-preview.5 has been released which incorporates this pull request.:tada: Handy links: |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
/cc Ilya (@iSazonov)
PR Summary
Refactoring & Streamed Input Support
Additional tests have been added to cover this behaviour. Details below.
Behaviour of Piped Input
A Primitive Value
System.IO.FileInfo
String
Array of Primitives
Examples
PR Context
Format-Hex needs a bit more versatility and to be able to handle piped input in a more effective manner.
PR Checklist