Make command searcher not use wildcard search for execution by TravisEz13 · Pull Request #9202 · PowerShell/PowerShell · GitHub

PR Summary

Make command searcher not use wildcard search for execution

PR Context

This is a Defense in Depth fix to prevent people from accidentally running a script.

For example, if a user attempted to run .\[my1].ps1 and there is a 1.ps1 in the same folder. 1.ps1 would be executed instead.
The fix allows tab completion and Get-Command to continue to work with the wildcards ([], ?, and *).

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Change is not breaking
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
User-facing changes
- Not Applicable
- OR
- Documentation needed
  - Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- Make sure you've added a new test if existing tests do not effectively test the code changed
  - Add [feature] to your commit messages if the change is significant or affects feature tests

…s in path or not using wildcards in the path.

…g path

If we want unambiguity, can we follow the practice we use in cmdlets? I mean that if name resolution returns several results, then throw.

/cc Michael Klement (@mklement0)

Ilya (@iSazonov) That code is already there. End the end, both code paths, use the same code. I doubt anyone actually wants to do execution based on wildcards. It can lead to executing unexpected files and VERY bad results.

Glad to see this is getting fixed; it addresses at least part of #4726, which also asks for the >, >> behavior to be fixed - will this PR address that too (haven't looked)?

Michael Klement (@mklement0) The intent was not to fix that issue. As #4726 does not directly affect execution, I would not think that the issue would be considered a Defense in Depth fix and I'd prefer to get this fix in before addressing that issue.

Thanks for clarifying, Travis Plunk (@TravisEz13) (but note that #4726 is about execution as well).

Nit comment remaining

Suggested change

      
                        HelpMessage='Wait for the debugger to attach to powershell before pester starts.  Debug builds only!')]
          
                        HelpMessage='Wait for the debugger to attach to PowerShell before Pester starts.  Debug builds only!')]

Should we document the command searcher process in Docs repo?

The command searcher itself is an implementation detail. We should document the search order for command execution.

…ll#9202)

Travis Plunk (TravisEz13) added 6 commits March 22, 2019 10:58

Add ability for searcher to search for commands using either wildcard…

6060fd0

…s in path or not using wildcards in the path.

make get-command tell command searcher to use wildcards when searchin…

2343357

…g path

Add tests for the various cases

5e0523f

Address Paul's comments

9b8f2f8

make test names static

38f0111

Address Paul's comments (some offline)

f143e17

Travis Plunk (TravisEz13) added Breaking-Change breaking change that may affect users CL-Engine Indicates that a PR should be marked as an engine change in the Change Log labels Mar 22, 2019

Travis Plunk (TravisEz13) added this to the 6.2.0-GA-Consider milestone Mar 22, 2019

Travis Plunk (TravisEz13) requested review from Bruce Payette (BrucePay) and Dongbo Wang (daxian-dbw) as code owners March 22, 2019 18:05

Travis Plunk (TravisEz13) requested review from Paul Higinbotham (PaulHigin) and Aditya Patwardhan (adityapatwardhan) March 22, 2019 18:05

start using HasFlag

ffc4ce1

Paul Higinbotham (PaulHigin) suggested changes Mar 22, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/CommandSearcher.cs Outdated

Comment thread src/System.Management.Automation/engine/CommandSearcher.cs Outdated

Travis Plunk (TravisEz13) added 2 commits March 22, 2019 11:22

start using HasFlag in second location

539a0d0

Fix CodeFactor issues

f79768b

Travis Plunk (TravisEz13) force-pushed the fix_command_searcher branch from da63bff to 44e90c0 Compare March 22, 2019 19:30

Travis Plunk (TravisEz13) requested a review from Paul Higinbotham (PaulHigin) March 22, 2019 19:45

Travis Plunk (TravisEz13) force-pushed the fix_command_searcher branch from 44e90c0 to f143e17 Compare March 22, 2019 19:48

Michael Klement (mklement0) mentioned this pull request Mar 22, 2019

Some scripts / files with wildcard metacharacter [ in the file name or path cannot be invoked or redirected to #4726

Closed

Fix check in fullPath codePath

cdbf1e9

Paul Higinbotham (PaulHigin) suggested changes Mar 22, 2019

View reviewed changes

Comment thread src/System.Management.Automation/engine/CommandSearcher.cs Outdated

Don't recreate resolvedPaths

4688ae8

Paul Higinbotham (PaulHigin) approved these changes Mar 22, 2019

View reviewed changes

This comment has been minimized.

Sign in to view

Steve Lee (SteveL-MSFT) approved these changes Apr 1, 2019

View reviewed changes

Travis Plunk (TravisEz13) added 2 commits April 1, 2019 16:49

delete pending tests which were made negative tests

85a8c85

fix PR feedback

0e4c566

Aditya Patwardhan (adityapatwardhan) reviewed Apr 1, 2019

View reviewed changes

Comment thread test/powershell/engine/Basic/CommandDiscovery.Tests.ps1 Outdated

Update test/powershell/engine/Basic/CommandDiscovery.Tests.ps1

66fc031

This comment has been minimized.

Sign in to view

Ilya (iSazonov) reviewed Apr 2, 2019

View reviewed changes

Comment thread test/powershell/engine/Basic/CommandDiscovery.Tests.ps1 Outdated

Update test/powershell/engine/Basic/CommandDiscovery.Tests.ps1

5d7bc15

Travis Plunk (TravisEz13) commented Apr 2, 2019

View reviewed changes

Comment thread test/powershell/engine/Basic/CommandDiscovery.Tests.ps1 Outdated

Update test/powershell/engine/Basic/CommandDiscovery.Tests.ps1

c965097

Aditya Patwardhan (adityapatwardhan) approved these changes Apr 2, 2019

View reviewed changes

Aditya Patwardhan (adityapatwardhan) merged commit 5e4b4d1 into PowerShell:master Apr 2, 2019

Travis Plunk (TravisEz13) deleted the fix_command_searcher branch April 2, 2019 18:57

Travis Plunk (TravisEz13) mentioned this pull request Apr 3, 2019

Document the Command Path Precedence MicrosoftDocs/PowerShell-Docs#4105

Closed

8 tasks

Ilya (iSazonov) assigned Aditya Patwardhan (adityapatwardhan) Apr 3, 2019

Michael Klement (mklement0) mentioned this pull request Apr 15, 2019

Namespace variable notation unexpectedly treats paths as wildcard expressions #9225

Closed

Dongbo Wang (daxian-dbw) mentioned this pull request Apr 16, 2019

CommandSearcher: treat invalid wildcard path as literal #7399

Closed

11 tasks

Ilya (iSazonov) mentioned this pull request Apr 18, 2019

NullReferenceException in Get-Command #9396

Closed

This was referenced Jun 1, 2019

v7.0.0-preview.1: can't open a URL with Start-Process #9791

Closed

Fix use of Start-Process http://bing.com #9793

Merged

Travis Plunk (TravisEz13) mentioned this pull request Sep 6, 2019

Tab complete changed in inconvenient way for PS7 Preview3 #10482

Closed

Michael Klement (mklement0) mentioned this pull request Nov 6, 2019

command with wildcard characters on path cannot be executed #10997

Closed

Michael Klement (mklement0) mentioned this pull request Apr 5, 2022

When New-Item -Path is combined with -Name, the -Path argument is inappropriately treated as a wildcard expression #17106

Closed

5 tasks

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Make command searcher not use wildcard search for execution (PowerShe…

09fbf78

…ll#9202)

-                      [string]$Title = 'PowerShell Core Tests'
+                      [string]$Title = 'PowerShell Core Tests',
+                      [Parameter(ParameterSetName='Wait', Mandatory=$true,
+                          HelpMessage='Wait for the debugger to attach to powershell before pester starts.  Debug builds only!')]

	HelpMessage='Wait for the debugger to attach to powershell before pester starts. Debug builds only!')]
	HelpMessage='Wait for the debugger to attach to PowerShell before Pester starts. Debug builds only!')]

Make command searcher not use wildcard search for execution by TravisEz13 · Pull Request #9202 · PowerShell/PowerShell · GitHub

Uh oh!

Make command searcher not use wildcard search for execution - #9202

Make command searcher not use wildcard search for execution#9202Aditya Patwardhan (adityapatwardhan) merged 44 commits intoPowerShell:masterPowerShell/PowerShell:masterfrom TravisEz13:fix_command_searcherTravisEz13/PowerShell:fix_command_searcherCopy head branch name to clipboard

Conversation

Travis Plunk (TravisEz13) commented Mar 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Ilya (iSazonov) commented Mar 22, 2019

Uh oh!

Travis Plunk (TravisEz13) commented Mar 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Michael Klement (mklement0) commented Mar 22, 2019

Uh oh!

Travis Plunk (TravisEz13) commented Mar 22, 2019

Uh oh!

Michael Klement (mklement0) commented Mar 22, 2019

Uh oh!

Uh oh!

This comment has been minimized.

Steve Lee (SteveL-MSFT) left a comment

Choose a reason for hiding this comment

Uh oh!

Steve Lee (SteveL-MSFT) Apr 1, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Ilya (iSazonov) commented Apr 3, 2019

Uh oh!

Travis Plunk (TravisEz13) commented Apr 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Make command searcher not use wildcard search for execution#9202
Aditya Patwardhan (adityapatwardhan) merged 44 commits into
PowerShell:masterfrom
TravisEz13:fix_command_searcher

Travis Plunk (TravisEz13) commented Mar 22, 2019 •
edited
Loading

Travis Plunk (TravisEz13) commented Mar 22, 2019 •
edited
Loading