FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enhanced Logging by JustinGrote · Pull Request #2200 · PowerShell/PowerShellEditorServices · GitHub

/ PowerShellEditorServices Public

Enhanced Logging - #2200

Merged
Andy Jordan (andyleejordan) merged 8 commits into
mainfrom
feature/logImprovements
Nov 15, 2024
ConversationCommits (8)ChecksFiles changed
Merged

Enhanced Logging#2200
Andy Jordan (andyleejordan) merged 8 commits into
mainfrom
feature/logImprovements

Conversation

Justin Grote (JustinGrote) commented Nov 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Align PsesLogLevel to MEL log levels
  • Adjust some logging verbosity levels for the PSES startup logging flow to move better.
  • Create a new LSP Log Debug Provider to get around limitations with the CSharp Omnisharp one.
  • Drop all Omnisharp logs to trace since they are just LSP related
  • Address LSP bugs by wiring up log levels in-band.

Should be merged with PowerShell/vscode-powershell#5065

Justin Grote (JustinGrote) requested a review from a team as a code owner November 15, 2024 04:24
Justin Grote (JustinGrote) marked this pull request as draft November 15, 2024 04:24
Justin Grote (JustinGrote) mentioned this pull request Nov 15, 2024
Merged
Justin Grote (JustinGrote) changed the title Enhance logging configuration and levels Enhanced Logging Nov 15, 2024
Justin Grote (JustinGrote) marked this pull request as ready for review November 15, 2024 06:55
Andy Jordan (andyleejordan) approved these changes Nov 15, 2024
View reviewed changes

Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Do you want to get this into the upcoming preview?

Andy Jordan (andyleejordan) deleted the feature/logImprovements branch November 15, 2024 21:55
Andy Jordan (andyleejordan) added the Issue-Enhancement A feature request (enhancement). label Nov 15, 2024
This was referenced Nov 15, 2024
Closed
Closed
Peter Tripp (notpeter) mentioned this pull request May 1, 2025
Closed
This was referenced Jun 21, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Andy Jordan (andyleejordan) andyleejordan approved these changes
Patrick Meinecke (SeeminglyScience) Awaiting requested review from SeeminglyScience

Assignees

Justin Grote (JustinGrote)

Labels

Issue-Enhancement A feature request (enhancement).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL