Add WindowActionOnEnd for Start-DebugAttachSession - #2252
Andy Jordan (andyleejordan) merged 1 commit into
Conversation
Sorry, something went wrong.
Adds the parameter `-WindowActionOnEnd` that corresponds to the new VSCode attach configuration option `temporaryConsoleWindowActionOnDebugEnd`.
There was a problem hiding this comment.
Pull Request Overview
This PR adds the -WindowActionOnEnd parameter to the Start-DebugAttachSession PowerShell command to control the behavior of temporary debug consoles after debugging sessions end. This parameter corresponds to the new VSCode attach configuration option temporaryConsoleWindowActionOnDebugEnd.
- Adds new -WindowActionOnEnd parameter with three possible values: Close, Hide, and Keep
- Updates command syntax documentation to include the new parameter
- Implements the parameter mapping to the debug configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| module/docs/Start-DebugAttachSession.md | Updates documentation to include new -WindowActionOnEnd parameter in syntax and parameter descriptions |
| module/PowerShellEditorServices/Commands/Public/Start-DebugAttachSession.ps1 | Adds parameter definition and implementation logic for -WindowActionOnEnd |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sorry, something went wrong.
|
|
||
| ### -WindowActionOnEnd | ||
|
|
||
| Specifies the action to take on the temporary debug console created by the debug client after the attached session ends. This corresponds to the VSCode attach configuration option `temporaryConsoleWindowActionOnDebugEnd`. Setting to `Close` will close the debug console, `Hide` will move back to the last debug console before the attach session started, and `Keep` (default) will keep the active terminal as the attached session. |
Copilot
AI
Aug 26, 2025
There was a problem hiding this comment.
The documentation states that Keep is the default value, but the parameter definition shows Default value: None. This inconsistency should be corrected - either update the parameter definition to show Keep as the default or clarify that None means the system default behavior.
Sorry, something went wrong.
Andy Jordan (andyleejordan)
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
PR Summary
Adds the parameter -WindowActionOnEnd that corresponds to the new VSCode attach configuration option
temporaryConsoleWindowActionOnDebugEnd.
PR Context
PR that added the VSCode debug option PowerShell/vscode-powershell#5255.