Fix #5086 - Invalid JSON in the snippets file - #5087
Merged
Andy Jordan (andyleejordan) merged 9 commits intoNov 13, 2024
Merged
Andy Jordan (andyleejordan) merged 9 commits into
Andy Jordan (andyleejordan) merged 9 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Olav Rønnestad Birkeland (o-l-a-v)
requested a review
from a team
as a code owner
November 8, 2024 13:57
Andy Jordan (andyleejordan)
approved these changes
Nov 13, 2024
Andy Jordan (andyleejordan)
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Love it, thanks!
Sorry, something went wrong.
Comment thread
.github/workflows/ci-test.yml
Comment thread
.github/workflows/ci-test.yml
Outdated
Comment thread
.github/workflows/ci-test.yml
Outdated
Comment thread
tools/testValidJson.ps1
Outdated
Comment thread
tools/testValidJson.ps1
Outdated
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
Co-authored-by: Andy Jordan <2226434+andyleejordan@users.noreply.github.com>
Comment thread
tools/testValidJson.ps1
Outdated
Andy Jordan (andyleejordan)
enabled auto-merge
November 13, 2024 19:26
Andy Jordan (andyleejordan)
added this pull request to the merge queue
Nov 13, 2024
Copy link
Copy Markdown
Member
|
Well that was annoying. A transitive dependency updated (I think the SDK does this when it runs in CI?) and I had to add three different iterations of essentially the same package to the Azure Artifacts feed. It's running again now. |
Sorry, something went wrong.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #5086
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.