Implement Extension Setting Categories - #5103
Merged
Justin Grote (JustinGrote) merged 1 commit intoNov 27, 2024
Merged
Justin Grote (JustinGrote) merged 1 commit into
Justin Grote (JustinGrote) merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Justin Grote (JustinGrote)
requested review from
Patrick Meinecke (SeeminglyScience) and
Andy Jordan (andyleejordan)
November 26, 2024 19:53
Justin Grote (JustinGrote)
enabled auto-merge (rebase)
November 26, 2024 19:53
Andy Jordan (andyleejordan)
approved these changes
Nov 27, 2024
Andy Jordan (andyleejordan)
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks, I love it. I used your same PowerShell snippet in your screenshot but ran it through Compare-Object, I think you're good! I tested this out and it's great.
Sorry, something went wrong.
Justin Grote (JustinGrote)
deleted the
justingrote/feature/settingGroups
branch
November 27, 2024 20:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
We have a lot of settings, so this organizes them into categories using the contributes sections feature of vscode. I applied some subjective "most commonly used" logic to the order of the categories and settings within the categories.
I did a check and it doesn't look like I missed any settings, they appear to all be there.
(what may not be clear is I switched branches between the two collections of package.json...)