FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix for "Suppress PSScriptAnalyzer Rule" snippets by TMA-2 · Pull Request #5110 · PowerShell/vscode-powershell · GitHub

Fix for "Suppress PSScriptAnalyzer Rule" snippets - #5110

Merged
Andy Jordan (andyleejordan) merged 1 commit into
PowerShell:mainfrom
TMA-2:main
Dec 3, 2024
Merged

Andy Jordan (andyleejordan) merged 1 commit into
PowerShell:mainfrom
TMA-2:main

Conversation

Jon (TMA-2) commented Dec 2, 2024
edited by JustinGrote
Loading

Copy link
Copy Markdown
Contributor

Fixes #5108. Also my first PR, so hopefully everything checks out!

PR Summary

  • Corrects a missing close comment in the Function rule snippet
  • Corrects the tab stop numbering in the Parameter rule snippet as well as duplicate use of $TM_SELECTED_TEXT
  • Adds a missing comma in The Scope rule snippet
  • Minor formatting

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • NA PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Fix for issue PowerShell#5108

- Corrects a missing close comment in the Function rule snippet
- Corrects the tab stop numbering in the Parameter rule snippet as well as duplicate use of `$TM_SELECTED_TEXT`
- Adds a missing comma in The Scope rule snippet
- Minor formatting
Jon (TMA-2) requested a review from a team as a code owner December 2, 2024 11:59

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Collaborator

Jon (@TMA-2) thanks for your submission! I'll try to take a look at it in the next two weeks.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks so much!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snippet Issues: Suppress PSScriptAnalyzer Rules malformed (scope, function, param)

3 participants


Back | FazBrowse Home | New Git URL