Overhaul linting, formatting, and testing infrastructure - #5190
Andy Jordan (andyleejordan) merged 8 commits into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR completely overhauls our linting, formatting, and testing infrastructure. It replaces legacy import and configuration patterns with modern TypeScript type imports and updated configuration files, while also revising workspace settings and dependency versions.
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated no comments.
Show a summary per file| File | Description |
|---|---|
| src/logging.ts | Modernized logger initialization using nullish assignment and updated imports |
| src/features/* | Updated type imports and removed eslint-disable comments for empty interfaces |
| src/extension.ts | Adjusted import types and refined inline comments |
| pwsh-extension-dev.code-workspace | Revised workspace settings with updated file patterns and new extension recommendations |
| package.json, eslint.config.mjs, etc. | Updated dependency versions and overhauled configuration to support new standards |
src/logging.ts:143
- The use of the nullish assignment operator (??=) is concise; ensure that the target environment and TypeScript version fully support this syntax.
this._channel ??= window.createOutputChannel(this.channelName, {log: true});
pwsh-extension-dev.code-workspace:314
- The new 'outFiles' pattern is more restrictive; make sure it matches all emitted JavaScript files required for proper source map support.
"${workspaceFolder:Client}/dist/*.js"
Sorry, something went wrong.
Patrick Meinecke (SeeminglyScience)
left a comment
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Justin Grote (JustinGrote)
left a comment
There was a problem hiding this comment.
LGTM! Nice work on the test fixes. Just some future notes.
Sorry, something went wrong.
| "@vscode/vsce": "^3.3.2", | ||
| "esbuild": "^0.25.4" | ||
| }, | ||
| "optionalDependencies": { |
There was a problem hiding this comment.
We probably should document somewhere why optionalDependencies vs devdependencies
Sorry, something went wrong.
There was a problem hiding this comment.
I'm really hoping it changes when I get back to trying #5063
Sorry, something went wrong.
Replaces #5188 with a whole overhaul of our linting, formatting, and testing infrastructure.