Fix tests on OneBranch - #5196
Merged
Andy Jordan (andyleejordan) merged 3 commits intoMay 21, 2025
Merged
Andy Jordan (andyleejordan) merged 3 commits into
Andy Jordan (andyleejordan) merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Andy Jordan (andyleejordan)
force-pushed
the
test/fix-tests
branch
from
bac9a14 to
b134c4f
Compare
May 21, 2025 23:28
Patrick Meinecke (SeeminglyScience)
approved these changes
May 21, 2025
Patrick Meinecke (SeeminglyScience)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Andy Jordan (andyleejordan)
marked this pull request as ready for review
May 21, 2025 23:37
Copy link
Copy Markdown
Collaborator
|
Late but LGTM as well |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleans up our sleeps and our unit test settings plus handles the edge case of OneBranch's non-default PowerShell installation, allowing us to cut an entire stage out of the build.