Fix startup timeout after adjusting sleeps - #5199
Merged
Andy Jordan (andyleejordan) merged 1 commit intoMay 22, 2025
Merged
Andy Jordan (andyleejordan) merged 1 commit into
Andy Jordan (andyleejordan) merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull Request Overview
Adjust the session startup timeout logic to account for a reduced sleep interval of 200ms between polls, and remove the old static warning threshold.
- Recompute numOfTries as timeoutSeconds * 5 to match 200ms sleeps
- Update warnAt to subtract a 30-second equivalent in tries instead of using the removed static
- Clarify sleep duration in comments
src/process.ts:286
- Update this comment to reflect the new polling interval (200ms) instead of 1 second.
// Check every second.
src/process.ts:282
- Add or update unit tests to verify the new polling logic (200ms sleeps) and ensure warnAt is calculated correctly after this change.
const numOfTries = // We sleep for 1/5 of a second each try
Sorry, something went wrong.
Comment thread
src/process.ts
Comment on lines
+283
to
+284
| 5 * this.sessionSettings.developer.waitForSessionFileTimeoutSeconds; | ||
| const warnAt = numOfTries - 5 * 30; // Warn at 30 seconds |
Copilot
AI
May 22, 2025
Copy link
There was a problem hiding this comment.
[nitpick] Replace magic numbers (5 and 30) with named constants (e.g., retriesPerSecond and warnThresholdSeconds) to clarify their purpose.
Suggested change
| 5 * this.sessionSettings.developer.waitForSessionFileTimeoutSeconds; | |
| const warnAt = numOfTries - 5 * 30; // Warn at 30 seconds | |
| PowerShellProcess.retriesPerSecond * this.sessionSettings.developer.waitForSessionFileTimeoutSeconds; | |
| const warnAt = numOfTries - PowerShellProcess.retriesPerSecond * PowerShellProcess.warnThresholdSeconds; // Warn at 30 seconds |
Sorry, something went wrong.
Copilot uses AI. Check for mistakes.
Patrick Meinecke (SeeminglyScience)
approved these changes
May 22, 2025
Patrick Meinecke (SeeminglyScience)
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glad I remembered this.