FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add an extended Snippet for Advanced Functions by kilasuit · Pull Request #5203 · PowerShell/vscode-powershell · GitHub

/ vscode-powershell Public

Add an extended Snippet for Advanced Functions - #5203

Merged
Justin Grote (JustinGrote) merged 12 commits into
PowerShell:mainfrom
kilasuit:5197
Jul 23, 2025
ConversationCommits (12)ChecksFiles changed
Merged

Add an extended Snippet for Advanced Functions#5203
Justin Grote (JustinGrote) merged 12 commits into
PowerShell:mainfrom
kilasuit:5197

Conversation

Ryan Yates (kilasuit) commented May 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

PR Summary

fixes #5197

Added snippet from ISE with minor edits

  • comment help inside instead of outside the function defintion
  • added clean block and link to docs on this

Adding based on this comment on bsky

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Ryan Yates (kilasuit) requested a review from a team as a code owner May 24, 2025 23:25
Justin Grote (JustinGrote) reviewed May 27, 2025
View reviewed changes

Justin Grote (JustinGrote) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Godo work on the snippet, I'm not quite sure how useful this is though, maybe it should be renamed Function-Advanced-Doc-Full-Example to indicate it is an example for all the potential options? I personally would never use this, it would take me just as long to clean it up as it would to just write it naked with intellisense :)

Comment thread snippets/PowerShell.json Outdated
Comment thread snippets/PowerShell.json Outdated
Comment thread snippets/PowerShell.json Outdated
Comment thread snippets/PowerShell.json Outdated
Comment thread snippets/PowerShell.json

Ryan Yates (kilasuit) commented May 28, 2025

Copy link
Copy Markdown
Contributor Author

Justin Grote (@JustinGrote) this was a C&P from the one in ISE with very minor edits
But will take comments on board and push an update shortly

Justin Grote (JustinGrote) commented May 28, 2025

Copy link
Copy Markdown
Collaborator

I'll merge it either way, but good to make it as useful as possible yeah?

Justin Grote (JustinGrote) enabled auto-merge (squash) June 1, 2025 15:22
Justin Grote (JustinGrote) approved these changes Jun 1, 2025
View reviewed changes

Justin Grote (JustinGrote) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me, nice work!

This comment was marked as duplicate.

Sign in to view

Justin Grote (JustinGrote) commented Jun 1, 2025

Copy link
Copy Markdown
Collaborator

Andy Jordan (@andyleejordan) not sure why it's waiting on codeql, I don't see it as an action...

Justin Grote (JustinGrote) commented Jul 23, 2025

Copy link
Copy Markdown
Collaborator

Andy Jordan (@andyleejordan) bump on this.

Andy Jordan (andyleejordan) changed the title Add an extended Snippet for Advanced Functions fixes #5197 Add an extended Snippet for Advanced Functions Jul 23, 2025
Andy Jordan (andyleejordan) approved these changes Jul 23, 2025
View reviewed changes

Andy Jordan (andyleejordan) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks!

Justin Grote (JustinGrote) merged commit 2093b3e into PowerShell:main Jul 23, 2025

Justin Grote (JustinGrote) commented Jul 23, 2025

Copy link
Copy Markdown
Collaborator

Thanks Ryan Yates (@kilasuit)!

Ryan Yates (kilasuit) deleted the 5197 branch July 23, 2025 19:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Andy Jordan (andyleejordan) andyleejordan approved these changes
Justin Grote (JustinGrote) JustinGrote approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add an extended Snippet for Advanced Functions

3 participants

Back | FazBrowse Home | New Git URL