Bump to Node 22.15.1 and remove node-fetch - #5214
Andy Jordan (andyleejordan) merged 3 commits into
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the extension’s supported VS Code version, bumps Node and TypeScript type dependencies, and removes the now-unnecessary node-fetch package.
- Raise engines.vscode to ^1.101.0
- Drop node-fetch and its type definitions in favor of Node’s built-in fetch
- Bump @types/node to match Node v22.15.1 and update @types/vscode
package.json:9
- Consider adding an engines.node field (e.g., "node": ">=22.15.1") to package.json to enforce the minimum Node.js runtime version required by this extension.
"vscode": "^1.101.0"
package.json:63
- Since node-fetch has been removed in favor of the native fetch API in Node.js, consider updating the README or CHANGELOG to document this change and any migration steps for consumers.
"node-fetch": "^2.7.0"
Sorry, something went wrong.
|
Andy Jordan (@andyleejordan) eslint got real mad at me for unchanged stuff, do we want to fix these or add a rules exclusion? |
Sorry, something went wrong.
|
Ah a few things missing. This is complicated enough that I documented it here: https://github.com/PowerShell/vscode-powershell/blob/main/docs/development.md#tracking-upstream-dependencies Mostly need to be sure to cross reference everything (which I think you did) and update both pipelines. I have generally gone ahead and fixed new ESLint errors rather than suppress them when updating Node.js. |
Sorry, something went wrong.
|
Andy Jordan (@andyleejordan) I rebased this commit and cleaned it up a bit, unless I was missing something in your comments it should be OK now and match your notes. There is no TSConfig update needed, and now it mostly just needs the vscode and node packages bumped in the private packages and should be good. |
Sorry, something went wrong.
|
Ran update again and updated the package feed. I now have to use artifacts-npm-credprovider to auth against, and that tool is so broken seriously it only worked once I deleted every line but registry=... from .npmrc. Even comments broke it |
Sorry, something went wrong.
|
Andy Jordan (@andyleejordan) thank you! |
Sorry, something went wrong.
Fixes #5213
PR Summary
Bumps to Node 22.15.1 and removes node-fetch. Requires VSCode v1.101 or higher for future extension releases.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.