FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Enhancements to WebcamVideoStream (VideoCapture Properties and Release) by karjanme · Pull Request #177 · PyImageSearch/imutils · GitHub

/ imutils Public

Enhancements to WebcamVideoStream (VideoCapture Properties and Release) - #177

Open
karjanme wants to merge 5 commits into
PyImageSearch:masterfrom
karjanme:master
ConversationCommits (5)ChecksFiles changed
Open

Enhancements to WebcamVideoStream (VideoCapture Properties and Release)#177
karjanme wants to merge 5 commits into
PyImageSearch:masterfrom
karjanme:master

Conversation

karjanme commented Feb 3, 2020

Copy link
Copy Markdown

Address a few limitations with WebcamVideoStream:

1.) Set resolution of the VideoCapture, or use a capture object with custom properties already set.
Based on feedback provided in #68 , the constructor has been improved to allow optional args for a VideoCapture object and a resolution tuple.
#68 (comment)

2.) Address #35 by releasing the VideoCapture when the WebcamVideoStream is stopped.

Thank you for the time you've already spent developing this awesome library.

karjanme commented Mar 19, 2020

Copy link
Copy Markdown
Author

@jrosebr1 Please consider this PR when you have time. Let me know if you have any feedback on it. Thank you!

makew0rld commented Mar 25, 2020

Copy link
Copy Markdown

Not the maintainer, but thanks for this! I would suggest default setting the resolution to something like (10000, 10000), as this will force OpenCV to use the highest possible resolution of the camera, which it doesn't do by default.

makew0rld reviewed Mar 25, 2020
View reviewed changes
Comment thread imutils/video/videostream.py Outdated
makew0rld reviewed Mar 25, 2020
View reviewed changes
Comment thread imutils/video/webcamvideostream.py Outdated

karjanme commented Mar 25, 2020

Copy link
Copy Markdown
Author

Not the maintainer, but thanks for this! I would suggest default setting the resolution to something like (10000, 10000), as this will force OpenCV to use the highest possible resolution of the camera, which it doesn't do by default.

@makeworld-the-better-one I like your idea, but I'll leave it up to the maintainer to decide how they want this to work. I defaulted the resolution here to (320, 240) because that is the default in the other existing classes VideoStream and PiVideoStream.

makew0rld mentioned this pull request Mar 26, 2020
Open

makew0rld commented Mar 26, 2020

Copy link
Copy Markdown

Thanks for the changes!

This was referenced Jan 15, 2021
Open
Closed

karjanme commented Jan 27, 2022

Copy link
Copy Markdown
Author

@ariG23498 please consider this PR to fix a couple issues that are frequently reported by other users.

matiasandina mentioned this pull request Apr 11, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
makew0rld makew0rld left review comments
h4k1m13or h4k1m13or approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL