FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Check the server certificate when ssl_verify_identity is set by SashaMIT · Pull Request #1282 · PyMySQL/PyMySQL · GitHub

  1. PyMySQL
  2. PyMySQL

Repository navigation

Check the server certificate when ssl_verify_identity is set #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 2 commits into from
Oct 18, 2026
+11 −6
Conversation 5 Commits 2 Checks 12 Files changed 2
Merged

Check the server certificate when ssl_verify_identity is set #1282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9dbae7
Check the server certificate when ssl_verify_identity is set.
SashaMIT Oct 9, 2026
a0f7724
simplify
methane Oct 15, 2026
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
13 changes: 9 additions & 4 deletions pymysql/connections.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -277,12 +277,17 @@ def _config(key, arg):
self._ssl_required = False
if not ssl_disabled:
if ssl_ca or ssl_cert or ssl_key or ssl_verify_cert or ssl_verify_identity:
ssl_verify_identity = bool(ssl_verify_identity)
if ssl_verify_identity:
verify_mode = True
elif ssl_verify_cert is not None:
verify_mode = ssl_verify_cert
else:
verify_mode = False
ssl = {
"ca": ssl_ca,
"check_hostname": bool(ssl_verify_identity),
"verify_mode": ssl_verify_cert
if ssl_verify_cert is not None
else False,
"check_hostname": ssl_verify_identity,
"verify_mode": verify_mode,
}
if ssl_cert is not None:
ssl["cert"] = ssl_cert
Expand Down
4 changes: 2 additions & 2 deletions pymysql/tests/test_connection.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -749,7 +749,7 @@ def test_ssl_connect(self):
)
assert create_default_context.called
assert dummy_ssl_context.check_hostname
assert dummy_ssl_context.verify_mode == ssl.CERT_NONE
assert dummy_ssl_context.verify_mode == ssl.CERT_REQUIRED
dummy_ssl_context.load_cert_chain.assert_called_with(
"cert",
keyfile="key",
Expand All @@ -772,7 +772,7 @@ def test_ssl_connect(self):
)
assert create_default_context.called
assert dummy_ssl_context.check_hostname
assert dummy_ssl_context.verify_mode == ssl.CERT_NONE
assert dummy_ssl_context.verify_mode == ssl.CERT_REQUIRED
dummy_ssl_context.load_cert_chain.assert_called_with(
"cert",
keyfile="key",
Expand Down
Loading
Back | FazBrowse Home | New Git URL