Fix invalid escape sequences - #639
Open
meator wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
meator
commented
Apr 13, 2024
Comment thread
src/future/backports/email/feedparser.py
Comment on lines
35
to
38
| NLCRE = re.compile('\r\n|\r|\n') | ||
| NLCRE_bol = re.compile('(\r\n|\r|\n)') | ||
| NLCRE_eol = re.compile('(\r\n|\r|\n)\Z') | ||
| NLCRE_eol = re.compile(r'(\r\n|\r|\n)\Z') | ||
| NLCRE_crack = re.compile('(\r\n|\r|\n)') |
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
These regexes look pretty broken to be honest. All of these should be raw string literals. There are probably more examples of this in the codebase.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to run
on this project (as the XBPS package manager does), a lot of SyntaxWarning: invalid escape sequence warnings are spewed:
./future/backports/email/_header_value_parser.py:662: SyntaxWarning: invalid escape sequence '\(' '(', '\(').replace( ./future/backports/email/_header_value_parser.py:663: SyntaxWarning: invalid escape sequence '\)' ')', '\)') ./future/backports/email/_header_value_parser.py:1349: SyntaxWarning: invalid escape sequence '\]' ''.join(ATOM_ENDS).replace('\\','\\\\').replace(']','\]'))).match ./future/backports/email/_header_value_parser.py:1352: SyntaxWarning: invalid escape sequence '\]' ''.join(TOKEN_ENDS).replace('\\','\\\\').replace(']','\]'))).match ./future/backports/email/_header_value_parser.py:1354: SyntaxWarning: invalid escape sequence '\]' ''.join(ATTRIBUTE_ENDS).replace('\\','\\\\').replace(']','\]'))).match ./future/backports/email/_header_value_parser.py:1357: SyntaxWarning: invalid escape sequence '\]' '\\','\\\\').replace(']','\]'))).match ./future/backports/email/_header_value_parser.py:1541: SyntaxWarning: invalid escape sequence '\ ' """ctext = <printable ascii except \ ( )> ./future/backports/email/_header_value_parser.py:1876: SyntaxWarning: invalid escape sequence '\ ' """ dtext = <printable ascii except \ [ ]> / obs-dtext ./future/backports/email/feedparser.py:37: SyntaxWarning: invalid escape sequence '\Z' NLCRE_eol = re.compile('(\r\n|\r|\n)\Z') ./future/backports/email/utils.py:68: SyntaxWarning: invalid escape sequence '\A' '([^\ud800-\udbff]|\A)[\udc00-\udfff]([^\udc00-\udfff]|\Z)').search ./future/backports/html/parser.py:31: SyntaxWarning: invalid escape sequence '\s' tagfind = re.compile('([a-zA-Z][-.a-zA-Z0-9:_]*)(?:\s|/(?!>))*') ./future/backports/html/parser.py:79: SyntaxWarning: invalid escape sequence '\s' endtagfind = re.compile('</\s*([a-zA-Z][-.a-zA-Z0-9:_]*)\s*>') ./future/backports/http/client.py:1: SyntaxWarning: invalid escape sequence '\_' """HTTP/1.1 client library ./future/backports/http/cookiejar.py:212: SyntaxWarning: invalid escape sequence '\d' "(\d\d\d\d) (\d\d):(\d\d):(\d\d) GMT$", re.ASCII) ./future/backports/http/cookiejar.py:293: SyntaxWarning: invalid escape sequence '\d' """^ ./future/backports/http/cookiejar.py:429: SyntaxWarning: invalid escape sequence '\s' non_junk, nr_junk_chars = re.subn("^[=\s;]*", "", text) ./future/backports/test/support.py:1945: SyntaxWarning: invalid escape sequence '\d' m = re.match("2.6.(\d{1,2})", kernel_version) ./future/backports/urllib/parse.py:957: SyntaxWarning: invalid escape sequence '\?' _queryprog = re.compile('^(.*)\?([^?]*)$')This PR fixes all of them.