Fix wasm test returncode - #100
Merged
JohanMabille merged 2 commits intoFeb 18, 2026
Merged
JohanMabille merged 2 commits into
JohanMabille merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Here the Test WebAssembly CI run: https://github.com/QuantStack/git2cpp/actions/runs/22138447532/job/63996152045 which shows all the tests passing: test_status.py::test_status_new_file[chromium---long---short] PASSED [ 99%] test_status.py::test_status_add_file[chromium---long---short] PASSED [100%] ==================================== PASSES ==================================== ======================= 124 passed in 266.67s (0:04:26) ======================== |
Sorry, something went wrong.
SandrineP
approved these changes
Feb 18, 2026
JohanMabille
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem with incorrect returncode of subprocess.run calls in wasm tests. The problem was actually in the teardown of the subprocess.run calls in the wasm testing framework, and not a wasm build issue as initially suspected. So now we no longer need to exclude some returncode checks in wasm tests.
Also implemented parents=True argument to Path.mkdir() in wasm tests as this is used in test_rm.py.