Add --abbrev-commit, --format=oneline and --oneline to the log subcommand - #118
ianthomas23 merged 3 commits into
Conversation
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 86.83% 86.40% -0.44%
==========================================
Files 60 60
Lines 2340 2420 +80
Branches 275 290 +15
==========================================
+ Hits 2032 2091 +59
- Misses 308 329 +21 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
ianthomas23
left a comment
There was a problem hiding this comment.
Just one change requested, and a note about future work.
Sorry, something went wrong.
|
|
||
| std::string message = commit.message(); | ||
| while (!message.empty() && message.back() == '\n') | ||
| message.pop_back(); |
There was a problem hiding this comment.
Please add surrounding curly braces
Sorry, something went wrong.
| if (!obj.has_value()) | ||
| { | ||
| throw git_exception("bad revision '" + rev + "'", git2cpp_error_code::BAD_ARGUMENT); | ||
| return; |
There was a problem hiding this comment.
No need for return after throwing
Sorry, something went wrong.
| } | ||
| else | ||
|
|
||
| if (!m_revisions.empty()) |
There was a problem hiding this comment.
I think you can use else if to avoid return statement in the previous if.
Sorry, something went wrong.
| std::cout << git_oid_tostr_s(&oid) << std::endl; | ||
| } | ||
| return; | ||
| } |
There was a problem hiding this comment.
Using else here would avoid the need for the previous return statement
Sorry, something went wrong.
Fix #91
Add --abbrev-commit, format=oneline and --oneline to the log subcommand
Add <rev> to the revparse subcommand
Add -annotate to the tag subcommand
(The last two ones being useful for the tests)