Add branches to push subcommand - #126
Merged
JohanMabille merged 4 commits intoApr 17, 2026
Merged
JohanMabille merged 4 commits into
JohanMabille merged 4 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 68.33333% with 38 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #126 +/- ##
==========================================
- Coverage 88.27% 86.52% -1.76%
==========================================
Files 61 61
Lines 2627 2730 +103
Branches 309 329 +20
==========================================
+ Hits 2319 2362 +43
- Misses 308 368 +60 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
SandrineP
force-pushed
the
push_branch
branch
2 times, most recently
from
c20f637 to
07a6ea8
Compare
April 7, 2026 14:16
SandrineP
marked this pull request as ready for review
April 7, 2026 15:25
SandrineP
marked this pull request as draft
April 13, 2026 13:08
for more information, see https://pre-commit.ci
SandrineP
marked this pull request as ready for review
April 17, 2026 11:25
Comment thread
src/subcommand/push_subcommand.cpp
Outdated
| { | ||
| const std::string name = br.first; | ||
| const git_oid& oid = br.second; | ||
| if (remotes_before_push.find(name) == remotes_before_push.end()) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| if (remotes_before_push.find(name) == remotes_before_push.end()) | |
| if (!remotes_before_push.contains(name)) |
Sorry, something went wrong.
Comment thread
src/subcommand/push_subcommand.cpp
Outdated
|
|
||
| for (const auto refspec : refspecs) | ||
| { | ||
| if (new_branches.find(refspec) == new_branches.end()) |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Suggested change
| if (new_branches.find(refspec) == new_branches.end()) | |
| if (!new_branches.contains(refspec)) |
Sorry, something went wrong.
JohanMabille
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #98
Add <branch> and --branches flag to push subcommand.