| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 88.52% 88.52%
=======================================
Files 62 62
Lines 2884 2884
Branches 358 358
=======================================
Hits 2553 2553
Misses 331 331 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
|
I've opted for a default timeout of 10 seconds. Wasm tests pass (https://github.com/QuantStack/git2cpp/actions/runs/25670073737/job/75352697692), and I've added an environment variable section to the online docs: https://git2cpp--133.org.readthedocs.build/en/133/ We're probably going to need a new page in the online docs to explain how and why the wasm build is different to a real computer, but that is future work. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
WIP to add a timeout to wasm http requests. Such requests are synchronous blocking requests so we cannot obtain any feedback to present to the user whilst they are underway, and we have to wait until the corresponding http reply is received in full. These requests can take a long time fi they are clones of a large repo, as lots of data needs to be transferred back to us and usually this is a two-step return as it has to be via a CORS proxy. In the event of the request failing, if there isn't a timeout then the operation will block forever and cockle will be unresponsive forever. Note that this is the stage that occurs before the returned data is processed for which we do have progress reported to the user.
Ideally we'd use an asynchronous non-blocking request for this and it is part of our long term plan to implement asynchronous emscripten-forge terminal and kernel packages, but this is not yet available and is non-trivial to implement now.
Here there is a default timeout of 10 seconds (this is TBD really) and it can be overridden by the user via an environment variable:
export GIT_HTTP_TIMEOUT=20This is a WIP as there is more to do: