Fix cursor showing and hiding - #141
Merged
JohanMabille merged 2 commits intoApr 17, 2026
Merged
JohanMabille merged 2 commits into
JohanMabille merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ianthomas23
marked this pull request as ready for review
April 17, 2026 14:30
JohanMabille
approved these changes
Apr 17, 2026
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #141 +/- ##
==========================================
- Coverage 88.27% 87.23% -1.04%
==========================================
Files 61 61
Lines 2627 2633 +6
Branches 309 310 +1
==========================================
- Hits 2319 2297 -22
- Misses 308 336 +28 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cursor showing and hiding logic that I previously implemented via the cursor_hider scope object was buggy in that it could end up leaving the cursor hidden at the end of a git2cpp command. This would happen, for example, using a prompt_input which ensures that the cursor is enabled when the prompt is shown and then hides it at the end. The solution, in the presence of potentially nested cursor_hider objects, is to keep a static count of the number of active scope objects and ensure the cursor is shown when this goes down to zero.
It does introduce a static variable which isn't ideal but it is only a single unsigned int.
This is very hard to test, so I am not doing so in CI but I have tested it manually in both macos and wasm builds.