Refactored git_strarray_wrapper - #171
Merged
JohanMabille merged 3 commits intoJun 25, 2026
Merged
JohanMabille merged 3 commits into
JohanMabille merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 66.10169% with 20 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 88.39% 86.55% -1.84%
==========================================
Files 62 63 +1
Lines 2974 2991 +17
Branches 373 372 -1
==========================================
- Hits 2629 2589 -40
- Misses 345 402 +57 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
SandrineP
reviewed
Jun 24, 2026
Comment thread
src/subcommand/push_subcommand.cpp
Outdated
Comment thread
src/wrapper/repository_wrapper.hpp
Outdated
| // Tags | ||
| // git_strarray_wrapper tag_list_match(std::string pattern); | ||
| // strarray_view_wrapper tag_list_match(std::string pattern); | ||
| std::vector<std::string> tag_list_match(std::string pattern); |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
Wasn't this a placeholder to be replaced by the line above after this refactoring ?
Sorry, something went wrong.
JohanMabille
force-pushed
the
array_wrapper
branch
from
d18a0b3 to
95aa003
Compare
June 25, 2026 12:08
for more information, see https://pre-commit.ci
SandrineP
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108
This renames the git_strarray_wrapper class into strarray_view_wrapper and adds the strarray_owned_wrapper class.