Fix handling sequences of libgit2 read calls - #183
Merged
JohanMabille merged 2 commits intoSep 15, 2026
Merged
JohanMabille merged 2 commits into
JohanMabille merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 88.18% 88.22% +0.03%
==========================================
Files 63 63
Lines 2997 2997
Branches 376 376
==========================================
+ Hits 2643 2644 +1
+ Misses 354 353 -1 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Wasm tests all passing https://github.com/QuantStack/git2cpp/actions/runs/34966260865 |
Sorry, something went wrong.
JohanMabille
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in handling the sequences of libgit2 read calls in the wasm build for clones of some medium-sized repos. Essentially it removes an assumption about the sequence of libgit2 calls which is true for most but not all clone actions.
Before this fix:
After this fix: