Override core.filemode=false in wasm build - #189
Merged
JohanMabille merged 2 commits intoOct 7, 2026
Merged
JohanMabille merged 2 commits into
JohanMabille merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #189 +/- ##
==========================================
- Coverage 88.35% 88.24% -0.12%
==========================================
Files 63 64 +1
Lines 2997 3002 +5
Branches 376 376
==========================================
+ Hits 2648 2649 +1
- Misses 349 353 +4 ☔ View full report in Codecov by Harness.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Wasm tests succeed in https://github.com/QuantStack/git2cpp/actions/runs/37608961186. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
The code coverage is reduced as this change is in wasm-specific code and we do not check coverage for such code paths. |
Sorry, something went wrong.
JohanMabille
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR overrides the core.filemode config setting so that it is false in wasm builds. Without this, if you git clone a repo in JupyterLite that contains files with executable flags set, after refreshing the browser tab those file retrieved from the JupyterLite drive no longer have those executable flags set and are hence identified as changed.
The cockle emscripten filesystem does support storing of file permissions, it is only the JupyterLite shared drive that does not. The workaround here essentially means that wasm use of git2cpp is like on Windows where file permissions do not work via chmod. Longer term the correct fix for this is for the JupyterLite drive to fully support file permissions (and timestamps, etc).