Checkout subcommand - #21
Merged
JohanMabille merged 4 commits intoJul 22, 2025
Merged
JohanMabille merged 4 commits into
JohanMabille merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ianthomas23
approved these changes
Jul 22, 2025
ianthomas23
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @JohanMabille.
Sorry, something went wrong.
Comment thread
test/test_checkout.py
|
|
||
| checkout_cmd = [git2cpp_path, 'checkout', 'foregone'] | ||
| p = subprocess.run(checkout_cmd, capture_output=True, cwd="test/data/status_data", text=True) | ||
| assert(p.stdout == ''); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The python assert here doesn't actually need the brackets. But we already have a few of these, so we can just leave them until we have some linting set up on the test code and that will clean them up.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I can also make a cleanup pass in a dedicated PR.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.