Add colours to status subcommand - #41
ianthomas23 merged 7 commits into
Conversation
Sorry, something went wrong.
| signature_wrapper committer = signature_wrapper::get_commit_committer(commit); | ||
|
|
||
| std::cout << "\033[0;33m" << "commit " << buf << "\033[0m" << std::endl; | ||
| std::cout << message_colour.at("yellow") << "commit " << buf << message_colour.at("colour_close") << std::endl; |
There was a problem hiding this comment.
Nice to see use of colour rather than color!
Sorry, something went wrong.
| { | ||
| std::cout << e.status << e.item << std::endl; | ||
| if (is_long) | ||
| std::cout << colour << e.status << e.item << message_colour.at("colour_close") << std::endl; |
There was a problem hiding this comment.
Should this line be indented a few spaces? And the line 2 below this.
Sorry, something went wrong.
ianthomas23
left a comment
There was a problem hiding this comment.
I've confirmed that this works well for me locally.
Just one tiny nit, otherwise good to merge.
Sorry, something went wrong.
|
|
||
| if (sl.has_tobecommited_header()) | ||
| { | ||
| stream_colour_fn colour = termcolor::green; |
There was a problem hiding this comment.
There's an unnecessary double space here.
Sorry, something went wrong.
|
Note to self: need to add termcolor-cpp to emscripten-forge recipe. |
Sorry, something went wrong.
ianthomas23
left a comment
There was a problem hiding this comment.
Thanks @SandrineP
Sorry, something went wrong.
Add colours to status subcommand