FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixed most of commands creating a git repo instead of throwing an error by JohanMabille · Pull Request #42 · QuantStack/git2cpp · GitHub

Repository navigation

Fixed most of commands creating a git repo instead of throwing an error - #42

Merged
ianthomas23 merged 2 commits into
QuantStack:mainfrom
JohanMabille:repository_open
Sep 5, 2025
Merged

ianthomas23 merged 2 commits into
QuantStack:mainfrom
JohanMabille:repository_open

Conversation

JohanMabille commented Sep 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Currently, most of the commands create a .git folder instead of throwing an exception when we execute them in a non-git folder, like git does.

Copy link
Copy Markdown
Member

Are the files added to test/data/status_data/embedded_git needed?

SandrineP commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

test/data/status_data/embedded_git shouldn't exist anymore. I believe I removed it in a previous PR.

Copy link
Copy Markdown
Member Author

Are the files added to test/data/status_data/embedded_git needed?

Definitely not, looks like I reintroduced them by mistake

ianthomas23 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks @JohanMabille

ianthomas23 merged commit c9d6331 into QuantStack:main Sep 5, 2025
1 check passed
JohanMabille deleted the repository_open branch September 8, 2025 06:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL