Allow a CommWidget to send and receive binary messages - #39
Open
davidbrochart wants to merge 2 commits into
Open
davidbrochart wants to merge 2 commits into
davidbrochart wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
trungleduc
approved these changes
May 21, 2025
Comment thread
src/ypywidgets/comm.py
| self._comm.send(buffers=[reply]) | ||
| if message[1] == YSyncMessageType.SYNC_STEP2: | ||
| self._ydoc.observe(self._send) | ||
| elif message_type == 2: |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Maybe an ENUM for this value?
Sorry, something went wrong.
Comment thread
src/ypywidgets/comm.py
Comment on lines
+80
to
+81
| def on_receive(self, callback: Callable[[bytes], None]): | ||
| self._on_receive = callback |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Is a setter enough? Not sure there is a use case for this, but I generally prefer allowing registering multiple handlers for the on message event.
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.