Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I assume this cannot work until MatrixAlgebraKit is changed as well? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Yes, unless I now only change the hermitian case? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
GPU failures are unrelated, LGTM as this resolves some of the errors we are now consistently having in our tests. |
Sorry, something went wrong.
kshyatt
approved these changes
Jan 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issues with eigenvalues of diagonal arrays now being sorted, and similarly the matrix of eigenvectors no longer being diagonal.
Currently in MatrixAlgebraKit, this is only the case for eigh, and not eig, but I already fixed the eig case here as well for when we (presumably) make these consistent.