Small fixes for upstream + CUDA - #366
Merged
kshyatt merged 6 commits intoFeb 6, 2026
Merged
kshyatt merged 6 commits into
kshyatt merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Sorry, something went wrong.
kshyatt
force-pushed
the
ksh/cuda_tweaks
branch
from
05a8a6b to
cf0f9c1
Compare
February 6, 2026 10:29
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Jutho
reviewed
Feb 6, 2026
Comment thread
ext/TensorKitChainRulesCoreExt/constructors.jl
Outdated
kshyatt
force-pushed
the
ksh/cuda_tweaks
branch
from
cf0f9c1 to
2d2abc5
Compare
February 6, 2026 13:19
lkdvos
reviewed
Feb 6, 2026
lkdvos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Left some small comments, otherwise looks great!
Sorry, something went wrong.
Comment thread
ext/TensorKitChainRulesCoreExt/linalg.jl
Outdated
Comment thread
src/tensors/tensor.jl
Outdated
Comment thread
ext/TensorKitCUDAExt/cutensormap.jl
Outdated
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
lkdvos
reviewed
Feb 6, 2026
Comment thread
src/tensors/tensor.jl
Outdated
lkdvos
previously approved these changes
Feb 6, 2026
kshyatt
enabled auto-merge (squash)
February 6, 2026 14:57
Jutho
previously approved these changes
Feb 6, 2026
Copy link
Copy Markdown
Member
|
It looks like there is a missing unthunk in my scale!! suggestion, apologies for that! |
Sorry, something went wrong.
lkdvos
approved these changes
Feb 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need these for various ops in PEPSKit