Fix truncrank when kept rank is larger than input rank - #368
Merged
lkdvos merged 2 commits intoFeb 8, 2026
Merged
lkdvos merged 2 commits into
lkdvos merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I wanted to directly short-circuit to the NoTruncation function, but then I noticed the rev option, which is absent in notrunc. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests.
|
Sorry, something went wrong.
lkdvos
approved these changes
Feb 8, 2026
lkdvos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for the fix and added test ❤️
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes truncrank when the rank to be kept is already larger than the input tensor, so it should be the same as notrunc. The old code breaks only when the fusion style is UniqueFusion (including Trivial and abelian symmetries).
I bumped into the issue in QuantumKitHub/PEPSKit.jl#314 for finite-T time evolution. The infinite-T PEPO D = 1, and I rely on truncrank(D) to automatically keep fewer than D singular values when possible.
There was a similar bug in eig(h)_trunc that can be solved by this PR, but I didn't add a test for it.