Allow BraidingTensor to have a custom storage type by kshyatt · Pull Request #393 · QuantumKitHub/TensorKit.jl · GitHub

This is probably the nicest way to unblock the various MPSKit changes. I found the similarmatrixtype approach the least gross looking way to achieve this, but open to other ideas.

The only thing missing here is the parser preprocessing for @planar, where we need to extract the storagetype to hand it over to the BraidingTensor constructor.

I will try to review asap, but I first have to catch up on the latest status of the treetransform stuff, as I never managed to review that part of the vectorize fusiontrees PR.

Codecov Report

❌ Patch coverage is 91.66667% with 7 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/tensors/braidingtensor.jl	88.00%	6 Missing ⚠️
src/planar/preprocessors.jl	95.65%	1 Missing ⚠️

Files with missing lines	Coverage Δ
ext/TensorKitAdaptExt.jl	61.53% <100.00%> (+11.53%)	⬆️
ext/TensorKitCUDAExt/TensorKitCUDAExt.jl	100.00% <100.00%> (ø)
ext/TensorKitCUDAExt/cutensormap.jl	74.66% <100.00%> (+0.69%)	⬆️
src/planar/preprocessors.jl	87.52% <95.65%> (+0.44%)	⬆️
src/tensors/braidingtensor.jl	70.39% <88.00%> (+0.91%)	⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Anything more need doing here or is this ready to go after #389?

Your PR no longer requires formatting changes. Thank you for your contribution!

I guess the main thing missing is still the @planar changes... I will try to find some time, but I seem to be having a million things 🙃

I'll work on the preprocessor, don't worry about it! But my solution might be a bit ugly...

OK, a lot of comments resolved (hopefully!)

CUDA test fail here seems unrelated, I'm running locally to see if I can repro

Aaaaaand I can't repro locally!

I've run the MPSKit tests that aren't already failing on QuantumKitHub/MPSKit.jl#416 against this branch, everything but Aqua passes. I'm running the algorithms tests in detail just to make sure as I suspect that's where any problem would surface.

Figured out one last MPSKit failure that was related -- an extension of braidingtensortype is needed at BlockTensorKit.jl, I'll make that PR once this is merged

One final suggestion from my side, but this definitely looks great, so feel free to merge with or without that.

Co-authored-by: Jutho <Jutho@users.noreply.github.com>

Co-authored-by: Lukas Devos <ldevos98@gmail.com>

Co-authored-by: Jutho <Jutho@users.noreply.github.com>

Looks good to me too, could you already increase the version to 0.17? Since this is breaking, we will have to do that anyways, so might as well and then start adding the other breaking stuff in too (CUDA etc)

bump minor version

Done! They're calling it the end of Friday snipe commit of the century

* Update changelog for v0.17.0 * Update CITATION.cff for v0.17.0 * Add #438 documentation to v0.17.0 changelog

kshyatt requested review from Jutho and borisdevos April 3, 2026 09:27

kshyatt mentioned this pull request Apr 6, 2026

Overhaul test infrastructure #389

Merged

kshyatt mentioned this pull request Apr 8, 2026

fix: improvements to bypass scalar indexing and improve GPU support #375

Merged

kshyatt force-pushed the ksh/cubt branch from c69cc40 to c7afa63 Compare April 14, 2026 11:57

Jutho reviewed Apr 14, 2026

View reviewed changes

Comment thread src/tensors/braidingtensor.jl Outdated

Jutho reviewed Apr 14, 2026

View reviewed changes

Comment thread src/tensors/braidingtensor.jl

kshyatt marked this pull request as ready for review April 15, 2026 13:09

kshyatt force-pushed the ksh/cubt branch from ab02606 to 6d0049a Compare April 15, 2026 19:00

lkdvos reviewed Apr 16, 2026

View reviewed changes

Comment thread src/tensors/braidingtensor.jl Outdated

Comment thread src/tensors/braidingtensor.jl Outdated

Comment thread src/tensors/braidingtensor.jl Outdated

Comment thread test/cuda/planar.jl Outdated

Comment thread Project.toml Outdated

Comment thread ext/TensorKitCUDAExt/cutensormap.jl

kshyatt force-pushed the ksh/cubt branch 2 times, most recently from f787d47 to e7361df Compare April 17, 2026 10:02

lkdvos reviewed Apr 17, 2026

View reviewed changes

Jutho reviewed Apr 17, 2026

View reviewed changes

Comment thread src/tensors/braidingtensor.jl Outdated

Jutho reviewed Apr 17, 2026

View reviewed changes

Comment thread src/tensors/braidingtensor.jl Outdated

Jutho reviewed Apr 17, 2026

View reviewed changes

Comment thread src/tensors/braidingtensor.jl Outdated

Jutho reviewed Apr 17, 2026

View reviewed changes

Comment thread src/tensors/braidingtensor.jl Outdated

kshyatt force-pushed the ksh/cubt branch from e7361df to acb439c Compare April 20, 2026 09:53

kshyatt force-pushed the ksh/cubt branch from 0a78629 to f6e9e42 Compare April 20, 2026 11:49

kshyatt marked this pull request as draft April 20, 2026 12:41

lkdvos reviewed Apr 20, 2026

View reviewed changes

Comment thread ext/TensorKitAdaptExt.jl Outdated

lkdvos reviewed Apr 22, 2026

View reviewed changes

Comment thread src/tensors/braidingtensor.jl Outdated

kshyatt force-pushed the ksh/cubt branch from 0964154 to 459d566 Compare April 23, 2026 06:25

kshyatt mentioned this pull request Apr 23, 2026

cond test fails depending on whether --fast is used in the testsuite #413

Closed

lkdvos reviewed Apr 23, 2026

View reviewed changes

Comment thread src/tensors/braidingtensor.jl Outdated

lkdvos reviewed Apr 23, 2026

View reviewed changes

Comment thread src/tensors/braidingtensor.jl Outdated

lkdvos reviewed Apr 23, 2026

View reviewed changes

Comment thread src/tensors/braidingtensor.jl Outdated

Jutho reviewed Apr 24, 2026

View reviewed changes

Comment thread src/tensors/braidingtensor.jl Outdated

kshyatt and others added 9 commits April 24, 2026 16:14

Allow BraidingTensor to have a custom storage type

2afcdfc

Remove extraneous lines

832fdf3

Co-authored-by: Jutho <Jutho@users.noreply.github.com>

More extraneous line removal

f4c7710

A little more cleanup

1ca35b6

Coverage

925c9c5

Update src/tensors/braidingtensor.jl

8e515b5

Co-authored-by: Lukas Devos <ldevos98@gmail.com>

Use braidingtensortype

9a07b42

Apply suggestions from code review

bd9d394

Co-authored-by: Lukas Devos <ldevos98@gmail.com>

Update src/tensors/braidingtensor.jl

a69385d

Co-authored-by: Jutho <Jutho@users.noreply.github.com>

kshyatt force-pushed the ksh/cubt branch from a007306 to a69385d Compare April 24, 2026 14:14

lkdvos reviewed Apr 24, 2026

View reviewed changes

lkdvos added the breaking label Apr 24, 2026

Update Project.toml

3f1fdd8

bump minor version

kshyatt enabled auto-merge (squash) April 24, 2026 14:28

lkdvos approved these changes Apr 24, 2026

View reviewed changes

kshyatt merged commit 518cb2a into main Apr 24, 2026
61 of 62 checks passed

kshyatt deleted the ksh/cubt branch April 24, 2026 21:02

lkdvos mentioned this pull request Jun 3, 2026

Release v0.17.0 #444

Merged

Jutho referenced this pull request Jun 5, 2026

Release v0.17.0 (#444 )

56158fc

* Update changelog for v0.17.0 * Update CITATION.cff for v0.17.0 * Add #438 documentation to v0.17.0 changelog

Allow BraidingTensor to have a custom storage type by kshyatt · Pull Request #393 · QuantumKitHub/TensorKit.jl · GitHub

Allow BraidingTensor to have a custom storage type - #393

Allow BraidingTensor to have a custom storage type#393kshyatt merged 10 commits intomainQuantumKitHub/TensorKit.jl:mainfrom ksh/cubtQuantumKitHub/TensorKit.jl:ksh/cubtCopy head branch name to clipboard

Conversation

kshyatt commented Apr 3, 2026

Uh oh!

kshyatt commented Apr 6, 2026

Uh oh!

Jutho commented Apr 7, 2026

Uh oh!

codecov Bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

kshyatt commented Apr 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lkdvos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kshyatt commented Apr 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kshyatt commented Apr 20, 2026

Uh oh!

kshyatt commented Apr 20, 2026

Uh oh!

kshyatt commented Apr 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kshyatt commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kshyatt commented Apr 24, 2026

Uh oh!

Uh oh!

Jutho commented Apr 24, 2026

Uh oh!

lkdvos left a comment

Choose a reason for hiding this comment

Uh oh!

kshyatt commented Apr 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Allow BraidingTensor to have a custom storage type#393
kshyatt merged 10 commits into
mainfrom
ksh/cubt

codecov Bot commented Apr 14, 2026 •
edited
Loading

github-actions Bot commented Apr 16, 2026 •
edited
Loading

kshyatt commented Apr 24, 2026 •
edited
Loading