define spacetype for TruncationSpace - #403
Merged
lkdvos merged 7 commits intoApr 17, 2026
Merged
lkdvos merged 7 commits into
lkdvos merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lkdvos
reviewed
Apr 16, 2026
lkdvos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Definitely okay with this change, but would you mind changing the @assert to throw(SpaceMismatch("spacetype of truncation strategy does not match spacetype of tensor")) (or a better worded message if you have inspiration, just quickly typed something here)
Sorry, something went wrong.
lkdvos
reviewed
Apr 16, 2026
lkdvos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
(you are right, sectortype is more appropriate :))
Sorry, something went wrong.
Comment thread
src/factorizations/truncation.jl
Outdated
Comment thread
src/factorizations/truncation.jl
Outdated
lkdvos
previously approved these changes
Apr 16, 2026
lkdvos
approved these changes
Apr 16, 2026
Merged
lkdvos
referenced
this pull request
Apr 24, 2026
* Update changelog for v0.16.4 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Bump version to v0.16.4 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Update CITATION.cff for v0.16.4 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * manual improvements of Changelog * amend changelog * delete compatcheck for failing julia 1 --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR defines spacetype for TruncationSpace and adds a test that spacetype matches between the vector to truncate and the strategy (else it will crash with a hard to read error). I expect the check to be done at compile time without any consequence on assembly code.