FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Bump minimum version of CUDA and cuTENSOR by kshyatt · Pull Request #404 · QuantumKitHub/TensorKit.jl · GitHub

/ TensorKit.jl Public

Bump minimum version of CUDA and cuTENSOR - #404

Merged
kshyatt merged 10 commits into
mainfrom
ksh/cuda_bump
Apr 27, 2026
ConversationCommits (10)ChecksFiles changed
Merged

Bump minimum version of CUDA and cuTENSOR#404
kshyatt merged 10 commits into
mainfrom
ksh/cuda_bump

Conversation

kshyatt commented Apr 17, 2026

Copy link
Copy Markdown
Member

No description provided.

lkdvos previously approved these changes Apr 17, 2026
View reviewed changes

kshyatt commented Apr 17, 2026

Copy link
Copy Markdown
Member Author

I'm running this locally to see if the failures for CUDA are related or not. We'll also need a TO tag first.

kshyatt commented Apr 17, 2026

Copy link
Copy Markdown
Member Author

Can't repro the factorization failures, annoying...

kshyatt commented Apr 18, 2026

Copy link
Copy Markdown
Member Author

Now needs the MAK bump which itself needs the Mooncake and Enzyme ones

kshyatt marked this pull request as draft April 21, 2026 12:44
Jutho mentioned this pull request Apr 22, 2026
Closed

codecov Bot commented Apr 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
ext/TensorKitCUDAExt/TensorKitCUDAExt.jl 100.00% <ø> (ø)
ext/TensorKitCUDAExt/cutensormap.jl 74.66% <100.00%> (ø)

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kshyatt marked this pull request as ready for review April 25, 2026 05:12

kshyatt commented Apr 25, 2026

Copy link
Copy Markdown
Member Author

OK I think this is good to go now that things are passing

kshyatt commented Apr 25, 2026

Copy link
Copy Markdown
Member Author

... or not. These chainrules failures are suprising to me, it seems it should be unrelated as this PR doesn't touch that code. Could it maybe be related to the MatrixAlgebraKit version bump, as a lot of the failures are in factorization related tests?

lkdvos commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Actually, it turns out that the chainrules is the same issue that should be resolved here: QuantumKitHub/MatrixAlgebraKit.jl#219 (at least, I assume so since it only affects the LQ decomposition)

Given that this failure is unrelated, if the tests pass we should probably try and merge this.

kshyatt commented Apr 27, 2026

Copy link
Copy Markdown
Member Author

Looking at the logs, all the failures are in the LQ tests mentioned above, so I am going to force-merge

kshyatt merged commit 518af61 into main Apr 27, 2026
56 of 62 checks passed
kshyatt deleted the ksh/cuda_bump branch April 27, 2026 10:13
lkdvos mentioned this pull request Jun 3, 2026
Merged
Jutho referenced this pull request Jun 5, 2026
Release v0.17.0 (#444)
56158fc 
* Update changelog for v0.17.0

* Update CITATION.cff for v0.17.0

* Add #438 documentation to v0.17.0 changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lkdvos lkdvos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL