Add square checks for project_(anti)hermitian and eigenvalue decompositions - #408
Merged
lkdvos merged 4 commits intoApr 23, 2026
Merged
lkdvos merged 4 commits into
lkdvos merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Jutho
reviewed
Apr 22, 2026
Comment thread
src/factorizations/factorizations.jl
Jutho
reviewed
Apr 22, 2026
Comment thread
src/factorizations/factorizations.jl
Jutho
approved these changes
Apr 22, 2026
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests.
|
Sorry, something went wrong.
Merged
lkdvos
referenced
this pull request
Apr 24, 2026
* Update changelog for v0.16.4 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Bump version to v0.16.4 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Update CITATION.cff for v0.16.4 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * manual improvements of Changelog * amend changelog * delete compatcheck for failing julia 1 --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Member
|
Currently the tests in QuantumKitHub/TNRKit.jl#177 are failing because of the error SpaceMismatch: tensor is not square: codomain (ℂ^1 ⊗ ℂ^2) ≠ domain (ℂ^1 ⊗ ℂ^2) during a truncated eigenvalue decomposition. Am I reading this error message wrong? Or is the error wrong? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Can you reproduce this? I might not be awake enough but the error looks correct to me, so I'm not entirely sure what is happening here |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #388