FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

`remove_gauge_dependence!` overloads by lkdvos · Pull Request #419 · QuantumKitHub/TensorKit.jl · GitHub

/ TensorKit.jl Public

remove_gauge_dependence! overloads - #419

Merged
lkdvos merged 5 commits into
mainfrom
ld-gaugeremoval
May 12, 2026
ConversationCommits (5)ChecksFiles changed
Merged

remove_gauge_dependence! overloads#419
lkdvos merged 5 commits into
mainfrom
ld-gaugeremoval

Conversation

lkdvos commented Apr 27, 2026

Copy link
Copy Markdown
Member

After MatrixAlgebraKit v0.6.6, these functions are now simply overloaded and the block implementation can be re-used

codecov Bot commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/factorizations/pullbacks.jl 88.23% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/factorizations/pullbacks.jl 70.45% <88.23%> (+70.45%) ⬆️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

lkdvos force-pushed the ld-gaugeremoval branch 2 times, most recently from 5572080 to 1990b05 Compare April 28, 2026 11:05

lkdvos commented Apr 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Needs QuantumKitHub/MatrixAlgebraKit.jl#221
Bypassed this by using default arguments

Jutho reviewed Apr 28, 2026
View reviewed changes
Comment thread src/factorizations/pullbacks.jl Outdated
lkdvos marked this pull request as ready for review April 28, 2026 14:23
lkdvos force-pushed the ld-gaugeremoval branch from bd17b3d to f30994b Compare May 9, 2026 20:41
lkdvos mentioned this pull request May 10, 2026
Merged
lkdvos requested a review from Jutho May 11, 2026 16:41
lkdvos force-pushed the ld-gaugeremoval branch from 52002c3 to b43819c Compare May 11, 2026 21:32
lkdvos reopened this May 12, 2026

lkdvos commented May 12, 2026

Copy link
Copy Markdown
Member Author

Fun fact, apparently the wording in the MatrixAlgebraKit linked PR auto closed this one ??

Jutho commented May 12, 2026

Copy link
Copy Markdown
Member

Ok, the argument composition of the remove_x_gauge_dependence functions is apparently quite inconsistent, which I did not realise. That is not very nice, but will unfortunately require yet another breaking update of MAK. Anyway, independent of this PR which looks good.

lkdvos merged commit aaa368c into main May 12, 2026
94 of 101 checks passed
lkdvos deleted the ld-gaugeremoval branch May 12, 2026 10:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Jutho Jutho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL