perf: Trivial symmetry performance improvements - #479
Merged
lkdvos merged 5 commits intoJul 14, 2026
Merged
lkdvos merged 5 commits into
lkdvos merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@kshyatt do you know if these AMD failures are the ones from the conj thing in Strided? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I see these intermittently on 1.10 and 1.12, I think they are unrelated to this PR. We should open an issue and I'll see if I can figure out what is going wrong. |
Sorry, something went wrong.
Merged
lkdvos
force-pushed
the
ld-trivialpermute
branch
from
29a1e89 to
381d813
Compare
July 14, 2026 13:00
Jutho
reviewed
Jul 14, 2026
Comment thread
src/tensors/tensoroperations.jl
Outdated
Jutho
approved these changes
Jul 14, 2026
Jutho
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
One remark, but otherwise looks good.
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 54 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
lkdvos
referenced
this pull request
Jul 15, 2026
* Update changelog for v0.17.1 * Bump version to v0.17.1 * Update CITATION.cff for v0.17.1 * Document #485 and MatrixAlgebraKit 0.6.9 bump in changelog * Address review comments: clarify Enzyme index-manip mode, note cuTENSOR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a slight follow-up on #476 which reduces a bit more of the overhead for Trivial sectortypes. Additionally a slight refactor to avoid some unnecessary respecialization for contract! implementations.