Enzyme doesn't need a custom rule for trace_permute - #480
Merged
lkdvos merged 2 commits intoJul 14, 2026
Merged
lkdvos merged 2 commits into
lkdvos merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Apparently this works now with a custom set of rules for subblock! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Sorry, something went wrong.
lkdvos
reviewed
Jul 14, 2026
lkdvos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🥳
Sorry, something went wrong.
lkdvos
approved these changes
Jul 14, 2026
Copy link
Copy Markdown
Member
Author
|
It seems to have helped with compile times too 🧐 |
Sorry, something went wrong.
kshyatt
marked this pull request as ready for review
July 14, 2026 13:44
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 53.33333% with 14 lines in your changes missing coverage. Please review.
|
Sorry, something went wrong.
Jutho
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that this seemed to be working sans custom rule locally. Let's see how it does for all the test cases.