Try combining the mul/planarcontract tests - #500
Merged
lkdvos merged 6 commits intoSep 15, 2026
Merged
lkdvos merged 6 commits into
lkdvos merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
kshyatt
force-pushed
the
ksh/mul_planar_combo
branch
from
b11f25f to
f1ddb6a
Compare
July 30, 2026 12:13
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests.
|
Sorry, something went wrong.
lkdvos
marked this pull request as ready for review
July 30, 2026 16:47
lkdvos
approved these changes
Jul 30, 2026
lkdvos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Seems to be working, ok for me if tests pass
Sorry, something went wrong.
kshyatt
force-pushed
the
ksh/mul_planar_combo
branch
from
b4afc99 to
eab9a41
Compare
August 3, 2026 08:50
kshyatt
force-pushed
the
ksh/mul_planar_combo
branch
from
72b1cad to
c833c7a
Compare
September 14, 2026 11:23
lkdvos
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more complicated braidings, planarcontract calls mul! so I would like to see if combining these cuts down test times and memory usage at all.