Fix @planar backend and allocator insertion - #505
Merged
lkdvos merged 1 commit intoAug 13, 2026
Merged
lkdvos merged 1 commit into
lkdvos merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
`_insert_planar_operations` rewrites the tensor calls to `GlobalRef(TensorKit, :planar*!)`, which `TO.insertargument` does not match, so `@planar backend=... ` and `@planar allocator=...` silently dropped both arguments from the planar calls. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests.
|
Sorry, something went wrong.
lkdvos
marked this pull request as ready for review
August 13, 2026 05:59
kshyatt
reviewed
Aug 13, 2026
Comment thread
test/tensors/planar.jl
kshyatt
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By the time the postprocessors run, _insert_planar_operations has rewritten the tensor calls to GlobalRef(TensorKit, :planar*!). TO.insertargument only matches GlobalRefs into TensorOperations, so @planar backend=... and @planar allocator=... silently dropped both arguments from the planar calls.
Adds a TensorKit-matching _insertargument, routes the @planar parser through insertplanarbackend/insertplanarallocator, and tests the expansion.
🤖 Generated with Claude Code