Fix --modules= parsing in the benchmark entry point - #506
Merged
lkdvos merged 1 commit intoAug 15, 2026
Merged
lkdvos merged 1 commit into
lkdvos merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests.
|
Sorry, something went wrong.
The pattern captured `(\w+)`, which stops at the first comma, so `--modules=linalg,tensornetworks` silently loaded only `linalg`. On top of that, `only(...)` was applied to the capture rather than to the match, which threw for any module name longer than one character. [skip ci]
lkdvos
force-pushed
the
fix/benchmark-modules-parsing
branch
from
de15c79 to
a39c5c4
Compare
August 15, 2026 09:57
lkdvos
marked this pull request as ready for review
August 15, 2026 09:57
kshyatt
approved these changes
Aug 15, 2026
kshyatt
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It's really abusive to ask me to review a regex
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in benchmark/benchmarks.jl:
🤖 Generated with Claude Code