FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

perf(workspace): debounce filter input in DataGridFilterBar by ZhuchkaTriplesix · Pull Request #654 · QueryaHub/Querya-Desktop · GitHub

perf(workspace): debounce filter input in DataGridFilterBar - #654

Merged
ZhuchkaTriplesix merged 1 commit into
devfrom
issue/651-debounce-datagrid-filter-bar
Aug 30, 2026
Merged

ZhuchkaTriplesix merged 1 commit into
devfrom
issue/651-debounce-datagrid-filter-bar

Conversation

Copy link
Copy Markdown
Member

Description

Resolves #651 by introducing a debounce timer for filter text input in DataGridFilterBar:

  1. Debounce Mechanism:

    • Added a 150ms debounce Timer to _DataGridFilterBarState.
    • Rapid keystrokes no longer trigger sequential full dataset filtering on each character.
    • Autocomplete suggestions continue to update instantly for zero typing lag.
  2. Immediate Executions & Cleanup:

    • Enter key submission (onSubmitted) cancels pending debounce and immediately triggers filtering.
    • Clear button tap cancels pending debounce and immediately clears the filter.
    • Timer is cleanly cancelled on widget dispose().
  3. Testing:

    • Added unit and widget tests in test/features/workspace/data_grid_filter_bar_test.dart verifying debounced emission, immediate Enter submission, and clear button cancellation.
    • All 183 tests pass with 0 analyze issues.

Closes #651

- Add 150ms debounce Timer for filter text changes in DataGridFilterBar
- Provide instant autocomplete suggestions on keystrokes while debouncing full dataset filter callbacks
- Execute filter immediately on Enter submission and clear button tap
- Cancel pending timers on widget disposal
- Add widget tests for debounced filtering and immediate submission

Closes #651
github-actions Bot added frontend Theme parser epic label: frontend performance Theme parser epic label: performance labels Aug 30, 2026
ZhuchkaTriplesix merged commit 270c90b into dev Aug 30, 2026
4 checks passed
ZhuchkaTriplesix mentioned this pull request Aug 30, 2026
ZhuchkaTriplesix deleted the issue/651-debounce-datagrid-filter-bar branch August 30, 2026 19:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Theme parser epic label: frontend performance Theme parser epic label: performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL