FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Nimble Next by younata · Pull Request #1068 · Quick/Nimble · GitHub

/ Nimble Public

Nimble Next - #1068

Draft
younata wants to merge 26 commits into
mainfrom
nimble-13
Draft

Nimble Next#1068
younata wants to merge 26 commits into
mainfrom
nimble-13

Conversation

younata commented Jul 29, 2023
edited
Loading

Copy link
Copy Markdown
Member

younata added this to the v13.0.0 milestone Jul 29, 2023

younata commented Aug 15, 2023
edited
Loading

Copy link
Copy Markdown
Member Author

Now that we require Sendable closures when using async toEventually/async expressions, this presents an issue integrating with Quick.

In Quick, the common/promoted styling is to declare variables as vars in an ExampleGroup (i.e. describe, context, or even the root example group in the spec method). In Swift 5.9, when you pass a var to a sendable closure, you have to explicitly declare it. i.e.:

var subject: SomeClass!

// ...

it("does something") {
    expect { [subject] in await subject!.value }.to(...)
    // Note: In the closure, the type of `subject` is changed from a force-unwrap optional to a standard optional.
    // that is, the `!` boilerplate is now required.
}

Which is a terrible experience. It would be awfully nice if Swift would let us implicitly capture that var and pass it along.

younata commented Oct 14, 2024

Copy link
Copy Markdown
Member Author

With the merging of #1167, all of the concurrency warnings are fixed (when running on Xcode 16).

Unfortunately, this refuses to build on pre-swift-6 versions of Xcode thanks to the use of sending, and there are even broken tests to go look through.

younata modified the milestones: v13.0.0, v14.0.0 Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL