Nimble 14: Fix broken tests in swift 6 - #1169
Closed
younata wants to merge 30 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Make Predicate's closure Sendable, and make Predicate Sendable when the returning value is Sendable
* Update Require DSL to largely be Sendable * Fix now-broken tests
* Make FailureMessage sendable. * Make MatcherResult conform to Sendable
Still more to do here. Will likely to require further refactoring
There are 2 subclasses which are also sendable/safe to use. And no one else can make subclasses outside of Nimble, so this is tolerable
…compatible with swift 6
younata
force-pushed
the
nimble-13-failing-tests
branch
from
259705b to
efd7a78
Compare
October 14, 2024 05:51
At least, as far as CI is concerned.
younata
force-pushed
the
nimble-13-failing-tests
branch
from
2ff6980 to
d28c8ed
Compare
October 15, 2024 03:47
Copy link
Copy Markdown
|
any update for this? i've been experiencing this error on xcode 16 (swift 6) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR should summarize what was changed and why. Here are some questions to
help you if you're not sure:
Checklist - While not every PR needs it, new features should consider this list: