FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[bsp][stm32][bluepill] fix README: wrong LED pin (PB2 -> PC13) and an empty list item by Ren6694 · Pull Request #11817 · RT-Thread/rt-thread · GitHub

/ rt-thread Public

[bsp][stm32][bluepill] fix README: wrong LED pin (PB2 -> PC13) and an empty list item - #11817

Open
Ren6694 wants to merge 2 commits into
RT-Thread:masterfrom
Ren6694:fix-blue-pill-readme
ConversationCommits (2)ChecksFiles changed
Open

[bsp][stm32][bluepill] fix README: wrong LED pin (PB2 -> PC13) and an empty list item#11817
Ren6694 wants to merge 2 commits into
RT-Thread:masterfrom
Ren6694:fix-blue-pill-readme

Conversation

Ren6694 commented Sep 21, 2026

Copy link
Copy Markdown

问题描述

bsp/stm32/stm32f103-blue-pill 的 README 里，板载 LED 的引脚号前后矛盾：

位置 内容
README_zh.md:33（板载资源） LED：1个 PB2
README.md:83（Onboard Resources） LED：PB2
README_zh.md:45（外设支持表） 黄色LED … PC13
README.md:220（Peripherals 表） LED … PC13
applications/main.c:19-20 /* defined the LED0 pin: PC13 */ / #define LED0_PIN GET_PIN(C, 13)
applications/arduino_pinout/README.md:35 8 (D8, LED_BUILTIN) … PC13 … 板载用户LED

PC13 是正确的，Blue Pill 的用户 LED 接在 PC13 上。除两处「板载资源」条目外，其余全部位置（代码、外设支持表、Arduino 引脚表）都说 PC13，PB2 看起来是从最初的 stm32f103-mini-system BSP 遗留下来的。

另外 README_zh.md 的「注意事项」段落末尾有一个悬空的列表项 - ，渲染出来是一个空的圆点。

改动内容

只改文档，共 2 个文件 3 行：

  1. README_zh.md — LED：1个 PB2 → LED：1个 PC13
  2. README.md — LED：PB2 → LED：PC13
  3. README_zh.md — 删除「注意事项」末尾的空列表项

验证方式

  • 全文检索确认：改动后 PB2 在 bsp/stm32/stm32f103-blue-pill 下已无 LED 相关匹配
    （注意 board/board.c:41 里的 APB2CLKDivider 含有 PB2 子串，属于误匹配，未改动）
  • 对照 applications/main.c 的 #define LED0_PIN GET_PIN(C, 13) 与外设支持表，确认 PC13 为正确值

未改动的内容

  • 没有改任何代码、rtconfig.h、.config 或工程文件
  • 没有新增文档文件
  • 没有无关格式化或批量替换

@Liang1795 麻烦有空看下，谢谢！

Signed-off-by: Ren6694 renxitao@stu.haut.edu.cn

docs: update readme for blue pill part1
3e27bb8 
Signed-off-by: Ren6694 <renxitao@stu.haut.edu.cn>
docs: update readme for blue pill part2
1d99087 
Signed-off-by: Ren6694 <renxitao@stu.haut.edu.cn>

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支（通常为 master）
    Keep the default branch (usually master) in Use workflow from
  • 在 branch 输入框填写 PR 分支 fix-blue-pill-readme
    Enter PR branch fix-blue-pill-readme in the branch field
  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后，提交将自动更新至 fix-blue-pill-readme 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix-blue-pill-readme branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

github-actions Bot added BSP: STM32 BSP related with ST/STM32 BSP labels Sep 21, 2026

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/stm32f103-blue-pill/README.md
  • bsp/stm32/stm32f103-blue-pill/README_zh.md

🏷️ Tag: bsp_stm32f103-blue-pill

Reviewers: @Liang1795

Changed Files (Click to expand)
  • bsp/stm32/stm32f103-blue-pill/README.md
  • bsp/stm32/stm32f103-blue-pill/README_zh.md

📊 Current Review Status (Last Updated: 2026-09-21 22:40 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

CLAassistant commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown


All committers have signed the CLA.

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL