FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

.SDcols peeling outer ( and edge case of :, and a logical of diff length by jangorecki · Pull Request #4470 · Rdatatable/data.table · GitHub

/ data.table Public

.SDcols peeling outer ( and edge case of :, and a logical of diff length - #4470

Merged
mattdowle merged 8 commits into
masterfrom
sdcols5
Jun 22, 2021
ConversationCommits (8)ChecksFiles changed
Merged

.SDcols peeling outer ( and edge case of :, and a logical of diff length#4470
mattdowle merged 8 commits into
masterfrom
sdcols5

Conversation

jangorecki commented May 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

closes #4231 and #4115

codecov Bot commented May 21, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@7ac2120). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 8f4efe1 differs from pull request most recent head bac9868. Consider uploading reports for the commit bac9868 to get more accurate results

@@            Coverage Diff            @@
##             master    #4470   +/-   ##
=========================================
  Coverage          ?   99.60%           
=========================================
  Files             ?       72           
  Lines             ?    13920           
  Branches          ?        0           
=========================================
  Hits              ?    13865           
  Misses            ?       55           
  Partials          ?        0
Impacted Files Coverage Δ
R/data.table.R 100.00% <ø> (ø)
src/assign.c 99.84% <ø> (ø)
src/between.c 100.00% <ø> (ø)
src/bmerge.c 100.00% <ø> (ø)
src/chmatch.c 100.00% <ø> (ø)
src/cj.c 100.00% <ø> (ø)
src/coalesce.c 100.00% <ø> (ø)
src/dogroups.c 100.00% <ø> (ø)
src/fastmean.c 100.00% <ø> (ø)
src/fcast.c 100.00% <ø> (ø)
... and 61 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ac2120...bac9868. Read the comment docs.

mattdowle commented May 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Great. The news item could be better. I try and include a code example (it doesn't have to be a reproducible example for a news item; just show the syntax), and where an error message is referred to, include the text of the error message. That way when a user searches for the error message, they find the news item.
I can make these changes to the news item.

ColeMiller1 commented May 22, 2020

Copy link
Copy Markdown
Contributor

If we bring back #4248 or adjust your #4174 , we would address the issue while having a nice refactor of some [.data.table code.

jangorecki linked an issue May 25, 2020 that may be closed by this pull request
.SDcols with logical vector #4115
Closed
jangorecki changed the title .SDcols peeling outer ( and edge case of : .SDcols peeling outer ( and edge case of :, and a logical of diff length May 25, 2020
jangorecki mentioned this pull request May 26, 2020
Closed
mattdowle added this to the 1.14.1 milestone Jun 22, 2021
mattdowle reviewed Jun 22, 2021
View reviewed changes
Comment thread R/data.table.R Outdated
if (anyNA(.SDcols))
stop(".SDcols missing at the following indices: ", brackify(which(is.na(.SDcols))))
if (is.logical(.SDcols)) {
if (length(.SDcols)!=length(x)) warning("logical vector in .SDcols should have equal length to number of columns in input table")

mattdowle Jun 22, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We usually try and be even more helpful in error messages by including the values of length(x) and length(.SDcols) in the message.

mattdowle merged commit 0a62718 into master Jun 22, 2021
mattdowle deleted the sdcols5 branch June 22, 2021 18:12
eutwt mentioned this pull request Mar 24, 2022
Open
jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
tdhock mentioned this pull request Dec 13, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mattdowle mattdowle left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.15.0

Development

Successfully merging this pull request may close these issues.

internal error when specifying .SDcols .SDcols with logical vector

3 participants

Back | FazBrowse Home | New Git URL