FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

dots were not passed along to as.IDate/as.ITime in IDateTime method. by JenspederM · Pull Request #4674 · Rdatatable/data.table · GitHub

dots were not passed along to as.IDate/as.ITime in IDateTime method. - #4674

Merged
mattdowle merged 6 commits into
masterfrom
JenspederM-patch-1
Aug 21, 2021
Merged

mattdowle merged 6 commits into
masterfrom
JenspederM-patch-1

Conversation

JenspederM commented Aug 17, 2020
edited by mattdowle
Loading

Copy link
Copy Markdown
Contributor

Closes #2402
Users were unable to supply tz or format in IDateTime, as dots were not passed through to submethods.

mattdowle added this to the 1.14.1 milestone Aug 21, 2021

codecov Bot commented Aug 21, 2021
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4674 (59395a9) into master (26394bc) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 59395a9 differs from pull request most recent head 304b6e5. Consider uploading reports for the commit 304b6e5 to get more accurate results

@@           Coverage Diff           @@
##           master    #4674   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          76       76           
  Lines       14612    14612           
=======================================
  Hits        14545    14545           
  Misses         67       67           
Impacted Files Coverage Δ
R/IDateTime.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26394bc...304b6e5. Read the comment docs.

mattdowle merged commit a87c9b0 into master Aug 21, 2021
mattdowle deleted the JenspederM-patch-1 branch August 21, 2021 02:39
jangorecki modified the milestones: 1.14.9, 1.15.0 Oct 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

format= argument to IDateTime()

3 participants


Back | FazBrowse Home | New Git URL