Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (78dee17) 97.47% compared to head (123ac11) 97.47%.
Report is 3 commits behind head on master.

@@           Coverage Diff           @@
##           master    #5857   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          80       80           
  Lines       14823    14829    +6     
=======================================
+ Hits        14448    14454    +6     
  Misses        375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I would add this example from #5309 as well -- surprising for the PR closing an issue on rbind() to only include tests on merge():

t2 = data.table(a = NA_real_, b = NA_real_, c = NA_real_, d= as.Date(NA))
t1 = data.table(a = 1.1, b = 1.1, c = 1.1, d = as.Date('2021-10-05'), e = as.POSIXct("2021-10-06 13:58:00 UTC"))
r2 = rbind(t1,t2, fill = T, use.names = F)

Or maybe:

error part in rbind is duplicate of #5444

Implies that a test already exists? If so please help point to it. But #5444 summary mentions R crashing, and #5309 was a normal R error, so I'm still not sure of the connection.

I would add this example from #5309 as well -- surprising for the PR closing an issue on rbind() to only include tests on merge():

t2 = data.table(a = NA_real_, b = NA_real_, c = NA_real_, d= as.Date(NA))
t1 = data.table(a = 1.1, b = 1.1, c = 1.1, d = as.Date('2021-10-05'), e = as.POSIXct("2021-10-06 13:58:00 UTC"))
r2 = rbind(t1,t2, fill = T, use.names = F)

Or maybe:

error part in rbind is duplicate of #5444

Implies that a test already exists? If so please help point to it. But #5444 summary mentions R crashing, and #5309 was a normal R error, so I'm still not sure of the connection.

Added the test.

Problem on both #5309 and #5444 was that non-existing columns were compared to existing columns due to fill. In #5444 this even led to a segfault (getAttrib on non-existing list column) while in #5309 it said to different attributes (getAttrib on non-existing data.table column)