FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use deparse() to cast calls to string when needed by MichaelChirico · Pull Request #6027 · Rdatatable/data.table · GitHub

/ data.table Public

Use deparse() to cast calls to string when needed - #6027

Merged
MichaelChirico merged 15 commits into
masterfrom
root-call
Jul 29, 2024
ConversationCommits (15)ChecksFiles changed
Merged

Use deparse() to cast calls to string when needed#6027
MichaelChirico merged 15 commits into
masterfrom
root-call

Conversation

MichaelChirico commented Mar 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Closes #6026.

There is some small overhead added here since jsub %iscall% f calls is.call() redundantly a few times. is.call() is ~50ns to run so I think this can be ignored.

MichaelChirico added this to the 1.16.0 milestone Mar 28, 2024
ColeMiller1 reviewed Mar 28, 2024
View reviewed changes
Comment thread R/data.table.R

codecov Bot commented Mar 28, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (566bff0) to head (919c262).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6027   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files          80       80           
  Lines       14915    14917    +2     
=======================================
+ Hits        14547    14549    +2     
  Misses        368      368

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MichaelChirico commented Mar 28, 2024
View reviewed changes
Comment thread inst/tests/tests.Rraw Outdated
MichaelChirico changed the title Don't cast jsub[[1]] to character if invalid Use deparse() to cast calls to string when needed Mar 28, 2024

github-actions Bot commented Jul 14, 2024 •
edited
Loading

Copy link
Copy Markdown

Generated via commit 5ba6112

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 11 minutes and 30 seconds

Time taken to run atime::atime_pkg on the tests: 4 minutes and 59 seconds

MichaelChirico commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

@jangorecki PTAL, straightforward enough. I do worry about deeper edgecases, would be good to put this through revdeps.

jangorecki commented Jul 28, 2024

Copy link
Copy Markdown
Member

I would go back to the issue and examine if what the problem exactly is and possible solutions.

MichaelChirico mentioned this pull request Jul 29, 2024
Closed
jangorecki approved these changes Jul 29, 2024
View reviewed changes

jangorecki left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

tested and looks good! Can we tweak news entry to not encourage users for this sub-efficient usage?

MichaelChirico merged commit 0a25b42 into master Jul 29, 2024
MichaelChirico deleted the root-call branch July 29, 2024 19:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ColeMiller1 ColeMiller1 left review comments
jangorecki jangorecki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

Using a function in env= fails

3 participants

Back | FazBrowse Home | New Git URL