| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Add setNumericRounding(0) initialisation and restore user's value on exit.
Add test file for testing setNumericRounding(0) initialisation in test.data.table().
|
I've updated this comment because the check results changed, even though I didn't change anything. Originally, the R-CMD-check / ubuntu-20.04 (release) (pull_request) and Autocomment atime-based performance regression analysis on PRs / comment (pull_request) checks failed and the R-CMD-check / windows-latest (devel) (pull_request) check was cancelled. I was surprised that the R-CMD-check failed, because before doing the PR I had built the package and run R CMD check data.table_1.15.99.tar.gz and it finished with Status: OK. However, when I looked at the PR again the next day, it said both of the R-CMD-check checks were successful. So now the only failure was the Autocomment check, which tdhock explained is expected to fail for PRs that come from forks. |
Sorry, something went wrong.
|
it is normal that Autocomment atime-based performance regression analysis on PRs / comment (pull_request) fails for PRs that come from forks. |
Sorry, something went wrong.
|
Thanks for the explanation @tdhock. |
Sorry, something went wrong.
|
LGTM! Two small tweaks & we can merge. |
Sorry, something went wrong.
Remove new test as requested by @MichaelChirico, to avoid nesting a test of test.data.table() in a script run by test.data.table().
Delete inst/tests/issue_6082_tests.Rraw because the test that used it was removed.
Move test.data.table() numeric rounding initialisation item from Bug Fixes to Notes as requested by @MichaelChirico.
|
@MichaelChirico Thanks for reviewing. I've deleted the test, deleted the file issue_6082_tests.Rraw, and moved the News item from Bug Fixes to Notes. |
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
|
Thanks @markseeto! You should have received an invite to become a project Member. The main thing this does is give you rights to create branches on this repo directly to facilitate future collaboration -- please do so as it makes the review process a bit easier. Welcome! |
Sorry, something went wrong.
|
@MichaelChirico Thanks for approving and thanks for the invitation. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Closes #6082
Added setNumericRounding(0) to initialise the numeric rounding value in test.data.table() to avoid failed tests if the user has set a different value. The user's value is restored on exit.