force loading bit64 earlier in print() - #6227
Merged
MichaelChirico merged 1 commit intoJul 8, 2024
Merged
MichaelChirico merged 1 commit into
MichaelChirico merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
|
Generated via commit cbba51a Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 12 minutes and 24 seconds Time taken to run atime::atime_pkg on the tests: 3 minutes and 20 seconds |
Sorry, something went wrong.
tdhock
approved these changes
Jul 8, 2024
tdhock
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
great thanks
nice test
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6224
My first thought was to add a format_col.integer64 method, but it turns out the fix is much easier, just need to force loading {bit64} one line earlier.